[webkit-reviews] review granted: [Bug 53134] Use Accelerate framework's vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp : [Attachment 87625] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 53134: Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

Attachment 87625: Patch
https://bugs.webkit.org/attachment.cgi?id=87625&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87625&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:311
> +	   printf("Getting image data with height or width equal to 0, early
return \n");

Remove this before committing.

> LayoutTests/fast/canvas/getPutImageDataPairTest.html:26
> +    r = b = g = Math.round(255*Math.random());
> +    var a = Math.random();

Tests that use randomness are annoying to debug. I don't really see the value
in using a random color; just hardcode something.