[webkit-reviews] review denied: [Bug 57409] [WinCairo] Implement Missing drawWindowsBitmap : [Attachment 87444] Implementation of missing drawWindowsBitmap for WinCairo port.

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 57409: [WinCairo] Implement Missing drawWindowsBitmap
https://bugs.webkit.org/show_bug.cgi?id=57409

Attachment 87444: Implementation of missing drawWindowsBitmap for WinCairo
port.
https://bugs.webkit.org/attachment.cgi?id=87444&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87444&action=review

It seems like this code and the code in GraphicsContext::releaseWindowsContext
are almost identical. Is it possible to refactor it out into a helper function?


> Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:160
> +					       CAIRO_FORMAT_ARGB32,
> +					       image->size().width(),
> +					       image->size().height(),
> +					       image->bytesPerRow());
> +

Please line these up with the opening (.

> Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:166
> +    cairo_scale(m_data->cr, 1.0, -1.0);

This should just be:

cairo_scale(m_data->cr, 1, -1);