[webkit-reviews] review granted: [Bug 57494] Update Windows production build logic for new production configurations : [Attachment 87596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 12:40:42 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 57494: Update Windows production build logic for new production
configurations
https://bugs.webkit.org/show_bug.cgi?id=57494

Attachment 87596: Patch
https://bugs.webkit.org/attachment.cgi?id=87596&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87596&action=review

> WebKitLibraries/win/tools/vsprops/production.vsprops:17
> +		PreprocessorDefinitions="NDEBUG;__PRODUCTION__=1"

Do we really need the NDEBUG here?


More information about the webkit-reviews mailing list