[webkit-reviews] review denied: [Bug 53134] Use Accelerate framework's vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp : [Attachment 87580] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 53134: Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

Attachment 87580: Patch
https://bugs.webkit.org/attachment.cgi?id=87580&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87580&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:483
> +	       for (int y = 0; y < height; ++y) {
> +		   for (int x = 0; x < width; x++) {
> +		       int basex = x * 4;
> +		       unsigned char alpha = srcRows[basex + 3];
> +		       if (alpha != 255) {
> +			   destRows[basex] = (srcRows[basex] * alpha + 254) /
255;
> +			   destRows[basex + 1] = (srcRows[basex + 1] * alpha +
254) / 255;
> +			   destRows[basex + 2] = (srcRows[basex + 2] * alpha +
254) / 255;
> +			   destRows[basex + 3] = alpha;
> +		       }
> +		   }

Isn't this loop missing:

	    srcRows += srcBytesPerRow;
	    destRows += destBytesPerRow;

which indicates that you didn't test it.