[webkit-reviews] review denied: [Bug 51955] Missing DOM bindings for a ping : [Attachment 87569] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 51955: Missing DOM bindings for a ping
https://bugs.webkit.org/show_bug.cgi?id=51955

Attachment 87569: Patch
https://bugs.webkit.org/attachment.cgi?id=87569&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87569&action=review

This test doesn't verify that setting the attribute through DOM actually makes
ping happen. I think that it should.

r- due to not testing that the attribute has any effect.

> LayoutTests/ChangeLog:10
> +	   * fast/dom/script-tests/ping-attribute-dom-binding.js: Added.

Please don't split tests into .html and .js parts. This is not helpful.