[webkit-reviews] review granted: [Bug 57419] Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering. : [Attachment 87545] Rebased against ToT.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57419: Move factory-like things in EventDispatcher::dispatchMouseEvent to a
factory, clean up names and ordering.
https://bugs.webkit.org/show_bug.cgi?id=57419

Attachment 87545: Rebased against ToT.
https://bugs.webkit.org/attachment.cgi?id=87545&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87545&action=review

> Source/WebCore/dom/MouseEvent.cpp:33
> +PassRefPtr<MouseEvent> MouseEvent::create(const AtomicString& eventType,
PassRefPtr<AbstractView> view, const PlatformMouseEvent& event, const IntPoint&
position, int detail, PassRefPtr<Node> relatedTargetArg)

No need for arg in relatedTargetArg.

> Source/WebCore/dom/MouseEvent.cpp:35
> +    bool cancelable = eventType != eventNames().mousemoveEvent;

Change this to isCancelable instead of cancelable please.

> Source/WebCore/dom/MouseEvent.cpp:38
> +    return MouseEvent::create(eventType,
> +	   true, cancelable, view,

Nitpickiest of nitpicks: I’d merge these two into one line.

> Source/WebCore/dom/MouseEvent.cpp:41
> +	   relatedTargetArg,  0, false);

Extra space here.

> Source/WebCore/dom/MouseEvent.h:49
> +	   static PassRefPtr<MouseEvent> create(const AtomicString& eventType,
PassRefPtr<AbstractView>, const PlatformMouseEvent&, const IntPoint&, int
detail, PassRefPtr<Node> relatedTargetArg);

No need for arg in relatedTargetArg.