[webkit-reviews] review denied: [Bug 53134] Use Accelerate framework's vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp : [Attachment 87558] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 53134: Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

Attachment 87558: Patch
https://bugs.webkit.org/attachment.cgi?id=87558&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87558&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:116
> +    static bool isCached = false;
> +    static bool result = false;
> +    
> +    if (!isCached) {
> +#if USE(ACCELERATE)
> +	   SInt32 version;
> +	   result = (Gestalt(gestaltSystemVersion, &version) == noErr &&
version > 0x1066);
> +#endif
> +	   isCached = true;
> +    }
> +    return result;

You can do this on one line in C++:

static haveVImageFix = Gestalt(gestaltSystemVersion, &version) == noErr &&
version > 0x1066;

hasFixedVImage() is not a very descriptive function name.