[webkit-reviews] review granted: [Bug 55150] [Cairo] Better separate the concerns of GraphicsContextCairo : [Attachment 85096] Patch with Carlos' and Brett's suggestions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 30 10:11:16 PDT 2011
Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 55150: [Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
Attachment 85096: Patch with Carlos' and Brett's suggestions
https://bugs.webkit.org/attachment.cgi?id=85096&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85096&action=review
LGTM. r=me. Just a minor change before landing:
> Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:134
> + cairo_scale(cr, 1.0, -1.0);
can you change it to webkit style and remove the dot please?
More information about the webkit-reviews
mailing list