[webkit-reviews] review granted: [Bug 57444] Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method. : [Attachment 87508] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 08:25:48 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 57444: Web Inspector: remove unnecessary newBody output parameter from
editScriptSource protocol method.
https://bugs.webkit.org/show_bug.cgi?id=57444

Attachment 87508: Patch.
https://bugs.webkit.org/attachment.cgi?id=87508&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87508&action=review

> Source/WebCore/inspector/Inspector.json:1195
>		       { "name": "stackFrames", "type": "array", "items": {
"$ref" : "CallFrame"}, "description": "New stack trace in case editing has
happened while VM was stopped." }

could you call this variable callFrames instead of stackFrames while you are
there?


More information about the webkit-reviews mailing list