[webkit-reviews] review requested: [Bug 47636] AX: GTK: ARIA role is not respected on <p> <label> <div> and <form> : [Attachment 87535] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 47636: AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Attachment 87535: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=87535&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
(In reply to comment #18)
> [...]
> I basically see two solutions from my ignorant perspective:
> 
>   1. Add more OR conditions to the "if (m_object->isGroup() || 
> m_object->isListItem())" statement, so it gets executed as well for 
> ParagraphRole, DivRole, FormRole and LabelRole.
> 
>   2. Make the new code in 
> AccessibilityRenderObject::determineAccessibilityRole() GTK-only, leaving it
as 
> it was before for the rest of the platforms.
> 
> Among these two options, I think (2) is the best one since it just changes
the 
> behaviour for GTK and the other platforms would keep working as they do right

> now, so I'll work on a new patch that way, but feel free to suggest me to do
it 
> in another way if you think it makes sense.

Attaching new patch addressing the problem with Mac in the previously mentioned
way: now only GTK is actually affected, and the rest of the ports should remain
unaltered.

Still, as the new roles are not GTK-specific, I maintained the changes in Mac
wrapper (explicit mapping to Group role) and Chromium (duplicating the web core
roles in those assertions).

I hope this time it's the right one. Will wait anyway for the EWS to run, to
gain peace of mind :-)