[webkit-reviews] review requested: [Bug 57434] [GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk : [Attachment 87487] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 02:28:25 PDT 2011


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 57434: [GTK] Implement scheduleWorkAfterDelay() in WorkQueueGtk
https://bugs.webkit.org/show_bug.cgi?id=57434

Attachment 87487: Patch
https://bugs.webkit.org/attachment.cgi?id=87487&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
- Implement scheduleWorkAfterDelay() using a timeout source
- Use an idle source instead of a timeout one with 0 for scheduleWork()
- Don't use a lock for g_source_attach() since it uses its own mutex internally

- Don't leak the GSource, g_source_attach() increments the source reference
counter
- Use a GSocket instead of GIOChannel
- Factor out performWork() and performWorkOnce() to avoid duplicated code


More information about the webkit-reviews mailing list