[webkit-reviews] review granted: [Bug 57430] [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled : [Attachment 87482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 02:06:20 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 57430: [Chromium] DumpRenderTree: Implement
LayoutTestController::setPluginsEnabled
https://bugs.webkit.org/show_bug.cgi?id=57430

Attachment 87482: Patch
https://bugs.webkit.org/attachment.cgi?id=87482&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87482&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1702
> +	   bool pluginsEnabled = arguments[0].toBoolean();
> +	   m_shell->preferences()->pluginsEnabled = pluginsEnabled;

nit: You can omit the variable pluginsEnabled.


More information about the webkit-reviews mailing list