[webkit-reviews] review granted: [Bug 9272] Left/Right borders/padding/margins are not always added correctly when rendering multiline inline boxes with bidi elements : [Attachment 87481] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 01:11:23 PDT 2011


Eric Seidel <eric at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 9272: Left/Right borders/padding/margins are not always added correctly
when rendering multiline inline boxes with bidi elements
https://bugs.webkit.org/show_bug.cgi?id=9272

Attachment 87481: Patch.
https://bugs.webkit.org/attachment.cgi?id=87481&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Fantastic!

I think an ideal follow-up pach would include splitting the
includeLeftEdge/includeRightEdge calculation out of
determineSpacingForFlowBoxes into a new function (determineEdges?) which can
use early return.  I think the code would end up even simpler then.

This looks great though!


More information about the webkit-reviews mailing list