[webkit-reviews] review denied: [Bug 53134] Use Accelerate framework's vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp : [Attachment 87448] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 53134: Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

Attachment 87448: Patch
https://bugs.webkit.org/attachment.cgi?id=87448&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87448&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:324
> +	       SInt32 majorVersion = 0;
> +	       SInt32 minorVersion = 0;
> +	       SInt32 bugFixVersion = 0;
> +	       Gestalt(gestaltSystemVersionMajor, &majorVersion);
> +	       Gestalt(gestaltSystemVersionMinor, &minorVersion);
> +	       Gestalt(gestaltSystemVersionBugFix, &bugFixVersion);
> +	       useVImage |= (majorVersion > 10);
> +	       useVImage |= (majorVersion == 10 && minorVersion > 6);
> +	       useVImage |= (majorVersion == 10 && minorVersion == 6 &&
bugFixVersion > 6);

You should check the error returned from Gestalt().

You can also do

SInt32 version;
if (Gestalt(gestaltSystemVersion, &version) == noErr && version > 0x1066)...