[webkit-reviews] review granted: [Bug 57353] Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x. : [Attachment 87412] Patch (v1)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 15:27:07 PDT 2011


Darin Adler <darin at apple.com> has granted Jia Pu <jpu at apple.com>'s request for
review:
Bug 57353: Autocorrection panel isn't positioned correctly in Safari (mac) when
the zooming is not 1x.
https://bugs.webkit.org/show_bug.cgi?id=57353

Attachment 87412: Patch (v1)
https://bugs.webkit.org/attachment.cgi?id=87412&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87412&action=review

> Source/WebCore/page/Frame.cpp:948
> +    Editor* editor = this->editor();
> +    if (editor)
> +	  
editor->dismissCorrectionPanel(ReasonForDismissingCorrectionPanelIgnored);

It is incorrect to null-check editor. The Editor is actually a data member of
Frame, and so can never be null.


More information about the webkit-reviews mailing list