[webkit-reviews] review denied: [Bug 57307] [GTK] Fix leaked pointer in FontGtk.cpp : [Attachment 87280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 13:22:34 PDT 2011


Martin Robinson <mrobinson at webkit.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 57307: [GTK] Fix leaked pointer in FontGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=57307

Attachment 87280: Patch
https://bugs.webkit.org/attachment.cgi?id=87280&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Great catch! I think we can use this opportunity to clean this code up a bit.
We should probably make utf16_to_utf8 return a char* instead of taking a char*&
(which is bad form, IMO). Then in the caller we should immediately place the
return value in a GOwnPtr<gchar> and remove the calls to g_free. This will
prevent any mistakes in the future as well.


More information about the webkit-reviews mailing list