[webkit-reviews] review requested: [Bug 57248] Occlusion issues with WebGL in Safari : [Attachment 87400] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 12:57:39 PDT 2011


Dean Jackson <dino at apple.com> has asked  for review:
Bug 57248: Occlusion issues with WebGL in Safari
https://bugs.webkit.org/show_bug.cgi?id=57248

Attachment 87400: Patch
https://bugs.webkit.org/attachment.cgi?id=87400&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
I've rewritten validateAttributes() as Ken suggested. I've also called it from
within reshape(). This isn't needed for the Mac port because the
GraphicsContext3D constructor calls it, but it seems the Qt port doesn't.

Now reshape uses Extensions3D to test for the ability to use the 24bit depth
buffer, which means it should be safe on any port that comes through here.


More information about the webkit-reviews mailing list