[webkit-reviews] review denied: [Bug 57248] Occlusion issues with WebGL in Safari : [Attachment 87385] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 57248: Occlusion issues with WebGL in Safari
https://bugs.webkit.org/show_bug.cgi?id=57248

Attachment 87385: Patch
https://bugs.webkit.org/attachment.cgi?id=87385&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
There is a check for the availability of GL_EXT_packed_depth_stencil in
GraphicsContext3D::validateAttributes higher up in the file, but it doesn't
guarantee that the logic here will be covered.

It would probably be best to rewrite validateAttributes in terms of the
Extensions3D class. For example:


Extensions3D* extensions = getExtensions();
if (m_attrs.stencil) {
    if (extensions->supports("GL_EXT_packed_depth_stencil")) {
	extensions->ensureEnabled("GL_EXT_packed_depth_stencil");
	...
    } ...
}

...

if (!isValidVendor ||
!extensions->supports("GL_ANGLE_framebuffer_multisample"))
    m_attrs.antialias = false;
else
    extensions->ensureEnabled("GL_ANGLE_framebuffer_multisample");