[webkit-reviews] review denied: [Bug 56000] Move the alignment related macros in Vector.h to the new Alignment.h. : [Attachment 85145] Proposed patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 56000: Move the alignment related macros in Vector.h to the new
Alignment.h.
https://bugs.webkit.org/show_bug.cgi?id=56000

Attachment 85145: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=85145&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85145&action=review

You're going to need to add forwarding headers to avoid breaking the mac build.


I wonder if a better name for the header would be AlignedBuffer.h since that
appears to be the primary thing that it provides so it is fine as is but
consider renaming the header.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:3126
> +		A19B86F7132670040037F979 /* Alignment.h in Headers */ = {isa =
PBXBuildFile; fileRef = A19B86F6132670040037F979 /* Alignment.h */; };

The changes in this file shouldn't be done. This file should be reverted.