[webkit-reviews] review denied: [Bug 56384] XML viewer is not shown when frame has non-null opener : [Attachment 87337] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 56384: XML viewer is not shown when frame has non-null opener
https://bugs.webkit.org/show_bug.cgi?id=56384

Attachment 87337: Patch
https://bugs.webkit.org/attachment.cgi?id=87337&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87337&action=review

> Source/WebCore/xml/XMLViewer.xsl:268
> +		   var domSubTreeModifiedListener;

This variable can be declared in the onWebKitXMLViewerLoad.

> Source/WebCore/xml/XMLViewer.xsl:274
> +			   if (!domSubTreeModifiedListener) {

Can the opposite happen?

> Source/WebCore/xml/XMLViewer.xsl:282
> +		       if (!window.onWebKitXMLViewerSourceXMLLoaded)

I don't follow the code. Can you explain what is happening in this load
handler?