[webkit-reviews] review requested: [Bug 50952] Inputs of type "text" and "search" should support interoperable "set direction" functionality : [Attachment 87313] A quick fix v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 07:18:51 PDT 2011


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 50952: Inputs of type "text" and "search" should support interoperable "set
direction" functionality
https://bugs.webkit.org/show_bug.cgi?id=50952

Attachment 87313: A quick fix v1
https://bugs.webkit.org/attachment.cgi?id=87313&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Aharon,

(In reply to comment #3)
> That is correct. The HTML5 spec before that change called for sending both
input and forminput. After the change, it just calls for sending input. I am
quoting from
http://dev.w3.org/html5/spec/Overview.html#text-state-and-search-state:
> 
> "If the element is mutable, the user agent should allow the user to change
the writing direction of the element, setting it either to a left-to-right
writing direction or a right-to-left writing direction. If the user does so,
the user agent must then run the following steps:
> "Set the element's dir attribute to "ltr" if the user selected a
left-to-right writing direction, and "rtl" if the user selected a right-to-left
writing direction.
> "Queue a task to fire a simple event that bubbles named input at the input
element."

Thank you for your clarification. I have written a change that sends an input
event after changing the "dir" attribute. Unfortunately, the layout test in
this change works only on Safari and Chrome because it requires a new
JavaScript function. (Should I change 'Skipped' files?)

Regards,

Hironori Bono


More information about the webkit-reviews mailing list