[webkit-reviews] review granted: [Bug 57335] Clean up bidiNext by abstracting repeated code : [Attachment 87310] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 57335: Clean up bidiNext by abstracting repeated code
https://bugs.webkit.org/show_bug.cgi?id=57335

Attachment 87310: Patch
https://bugs.webkit.org/attachment.cgi?id=87310&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87310&action=review

> Source/WebCore/rendering/InlineIterator.h:91
> +    using namespace WTF::Unicode;

Is it a common practice in WebKit to do "using namespace" inside a function?

> Source/WebCore/rendering/InlineIterator.h:111
> +    if (!resolver || !object->isRenderInline())

We should assert that object is not NULL or add an early exit.