[webkit-reviews] review denied: [Bug 57314] [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser : [Attachment 87282] proposed patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 57314: [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to
QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=57314

Attachment 87282: proposed patch
https://bugs.webkit.org/attachment.cgi?id=87282&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87282&action=review

r-, comments on irc

> Tools/MiniBrowser/qt/BrowserWindow.cpp:65
> +    if (m_windowOptions.printLoadedUrls)
> +	   connect(page(), SIGNAL(urlChanged(const QUrl&)), this,
SLOT(printURL()));

We typically normalize signal/slot names so Qt doesn't have to do it for us.
"urlChanged(const QUrl&)" -> "urlChanged(QUrl)"

printURL() should take the const QUrl& argument and print that instead of
fetching it from the view.