[webkit-reviews] review granted: [Bug 57299] Web Inspector: document Timeline domain, make timeline event types of type string. : [Attachment 87264] [PATCH] Patch that compiles.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 57299: Web Inspector: document Timeline domain, make timeline event types
of type string.
https://bugs.webkit.org/show_bug.cgi?id=57299

Attachment 87264: [PATCH] Patch that compiles.
https://bugs.webkit.org/attachment.cgi?id=87264&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87264&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:54
> +static const char EventDispatch[] = "EventDispatch";

Could we sort them alphabetically.

> Source/WebCore/inspector/front-end/TimelineAgent.js:37
> +    EventDispatch: "EventDispatch",

We should enumerated these constants in the .json scheme. This deserves its own
change, please file a bug and put a FIXME here.