[webkit-reviews] review denied: [Bug 56912] Web Inspector: move node searching and node highlight related methods from InspectorAgent to DOMAgent : [Attachment 86597] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 56912: Web Inspector: move node searching and node highlight related
methods from InspectorAgent to DOMAgent
https://bugs.webkit.org/show_bug.cgi?id=56912

Attachment 86597: Patch
https://bugs.webkit.org/attachment.cgi?id=86597&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86597&action=review

This is r- for several reasons, I wonder how it ended up with r+.

> Source/WebCore/inspector/DOMNodeHighlighter.h:37
> +namespace DOMNodeHighlighter {

Why custom namespace? What is wrong with using WebCore? This is not standard
approach afaik.

> Source/WebCore/inspector/DOMNodeHighlighter.h:39
> +void DrawNodeHighlight(GraphicsContext&, Node*);

Methods in WebCore start with lower case.

> Source/WebCore/inspector/Inspector.json:676
> +		   "name": "setSearchingForNode",

DOM domain is documented, you should not introduce commands that are not
documented into it.