[webkit-reviews] review requested: [Bug 32723] [Qt] QWebFrame::setUrl works only from second time if url fragment is present : [Attachment 87252] patch v3, storing the url used in setter

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> has asked	for
review:
Bug 32723: [Qt] QWebFrame::setUrl works only from second time if url fragment
is present
https://bugs.webkit.org/show_bug.cgi?id=32723

Attachment 87252: patch v3, storing the url used in setter
https://bugs.webkit.org/attachment.cgi?id=87252&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>
New version of the patch. After bug 29595 we have more tests to verify the
behavior.

This new version of the patch adds another auto test, that breaks previous idea
of using requestedUrl as fallback -- since load() calls can alter the
requestedUrl() without affecting the current url().

Benjamin, I've tried to get some referrer test working, by simulating a click,
but even then couldn't get the information available in QNAM (just inside debug
statements after the request). More investigation is needed to create such a
test, but it seems to me that this could be in another bug, like "[Qt] Create
autotest to verify HTTP Referrer when using setUrl() and load()" or something
similar. What do you think?