[webkit-reviews] review granted: [Bug 56063] Inline worker powered by blob URL does not work with files URL even if allowFileAccessFromFileURLs is enabled. : [Attachment 85268] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 17:00:52 PDT 2011


Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 56063: Inline worker powered by blob URL does not work with files URL even
if allowFileAccessFromFileURLs is enabled.
https://bugs.webkit.org/show_bug.cgi?id=56063

Attachment 85268: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=85268&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85268&action=review

This patch is amazing.	I love it!

> Source/WebCore/page/SecurityOrigin.cpp:83
> +    bool isBlobOrFileSystemProtocol = (m_protocol ==
BlobURL::blobProtocol()) || (m_protocol == "filesystem");

Will this build if ENABLE(BLOB) is false?  We might need some fancier ifdefing.


More information about the webkit-reviews mailing list