[webkit-reviews] review granted: [Bug 56424] add beforeload to icon and prefetch link rel types : [Attachment 87195] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 28 14:01:14 PDT 2011
Tony Gentilcore <tonyg at chromium.org> has granted Gavin Peters
<gavinp at chromium.org>'s request for review:
Bug 56424: add beforeload to icon and prefetch link rel types
https://bugs.webkit.org/show_bug.cgi?id=56424
Attachment 87195: Patch
https://bugs.webkit.org/attachment.cgi?id=87195&action=review
------- Additional Comments from Tony Gentilcore <tonyg at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87195&action=review
> LayoutTests/ChangeLog:8
> + Unfortunately, there's lots of expectations changes here, in a
strange
I don't see a lot of expectations changes, are files missing from the CL?
> LayoutTests/platform/chromium/test_expectations.txt:3340
> +BUGWK57259 : http/tests/misc/link-rel-icon-beforeload.html = FAIL PASS
Shouldn't this just be "FAIL" instead of "FAIL PASS". That way it will force
removing this line when that bug is fixed.
More information about the webkit-reviews
mailing list