[webkit-reviews] review granted: [Bug 57263] CGImageRefs must hold a strong reference to underlying data : [Attachment 87191] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 13:35:50 PDT 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 57263: CGImageRefs must hold a strong reference to underlying data
https://bugs.webkit.org/show_bug.cgi?id=57263

Attachment 87191: Patch
https://bugs.webkit.org/attachment.cgi?id=87191&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87191&action=review

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:58
> +RetainPtr<CGImageRef> ShareableBitmap::createCGImageCopy()

Lets call this makeCGImage.

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:65
> +RetainPtr<CGImageRef> ShareableBitmap::createCGImage()

This one too.


More information about the webkit-reviews mailing list