[webkit-reviews] review granted: [Bug 57262] ResourceError::certificate() should return a PCCERT_CONTEXT : [Attachment 87183] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Jeff Miller
<jeffm at apple.com>'s request for review:
Bug 57262: ResourceError::certificate() should return a PCCERT_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=57262

Attachment 87183: Patch
https://bugs.webkit.org/attachment.cgi?id=87183&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87183&action=review

> Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:62
> +PCCERT_CONTEXT ResourceError::certificate() const
> +{
> +    if (!m_certificate)
> +	   return 0;
> +    
> +    return
reinterpret_cast<PCCERT_CONTEXT>(CFDataGetBytePtr(m_certificate.get()));
> +}

Now I'm starting to wonder whether making m_certificate itself a PCCERT_CONTEXT
would be good. I guess one benefit of using CFDataRef is that we get to use
RetainPtr. We don't have a comparable smart pointer for PCCERT_CONTEXT.