[webkit-reviews] review requested: [Bug 57138] WebSocket urls should always be encoded as UTF-8 : [Attachment 87180] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 28 12:35:55 PDT 2011
Joe Mason <jmason at rim.com> has asked for review:
Bug 57138: WebSocket urls should always be encoded as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=57138
Attachment 87180: updated patch
https://bugs.webkit.org/attachment.cgi?id=87180&action=review
------- Additional Comments from Joe Mason <jmason at rim.com>
How's this?
Quite a few ways to implement Document::completeURLWithUTF8 - since from the
comments completeURL seems to be performance critical, I chose to make both
completeURL and completeURLWithUTF8 into inlines wrapper to a new func which
takes a bool param to force UTF-8 or not. The alternative is to not touch
completeURL, and copy the code to a new function which differs only in how it
uses m_decoder.
More information about the webkit-reviews
mailing list