[webkit-reviews] review granted: [Bug 57240] Web Inspector: brush up and rename debugger domain. : [Attachment 87155] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 09:58:30 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 57240: Web Inspector: brush up and rename debugger domain.
https://bugs.webkit.org/show_bug.cgi?id=57240

Attachment 87155: Patch
https://bugs.webkit.org/attachment.cgi?id=87155&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87155&action=review

> Source/WebCore/inspector/Inspector.json:1228
> +		   "name": "scriptFailedToParse",

scriptParsingFailed

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:181
> +void InspectorDebuggerAgent::setBreakpoint(ErrorString*, const String&
sourceId, int lineNumber, int columnNumber, const String& condition, bool
enabled, String* outBreakpointId, int* actualLineNumber, int*
actualColumnNumber)

setBreakpointBySourceId?


More information about the webkit-reviews mailing list