[webkit-reviews] review granted: [Bug 57168] Introduce EventDispatcher, the new common way to fire events. : [Attachment 87053] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57168: Introduce EventDispatcher, the new common way to fire events.
https://bugs.webkit.org/show_bug.cgi?id=57168

Attachment 87053: Patch
https://bugs.webkit.org/attachment.cgi?id=87053&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87053&action=review

>> Source/WebCore/dom/EventDispatcher.cpp:150
>> +	if (!m_node->inDocument() || m_ancestors.size())
> 
> This is the only non-obvious bit. Some events come in troves, with multiple
events dispatched as a result of one "dispatchFoo". Because they are now scoped
to the same EventDispatcher, the ancestor chain calculation happens only once
(yay!). So we need this extra check for size.

Maybe this needs a comment?