[webkit-reviews] review granted: [Bug 57233] move directionOfEnclosingBlock() to be global so that it could be reused : [Attachment 87149] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 57233: move directionOfEnclosingBlock() to be global so that it could be
reused
https://bugs.webkit.org/show_bug.cgi?id=57233

Attachment 87149: patch
https://bugs.webkit.org/attachment.cgi?id=87149&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87149&action=review

> Source/WebCore/ChangeLog:8
> +	   Provide global function directionOfEnclosingBlock(Node*) so that it
could be
> +	   reused in SelectionController and other functionalities that need
enclosing
> +	   block's direcionality, such as moving caret by word in visual order.

> +	   https://bugs.webkit.org/show_bug.cgi?id=57233.

This isn't really a standard way of writing a change long entry.  Please do:

move directionOfEnclosingBlock() to be global so that it could be reused
https://bugs.webkit.org/show_bug.cgi?id=57233

Provide global function directionOfEnclosingBlock(Node*) so that it could be
reused in SelectionController and other functionalities that need enclosing
block's direcionality, such as moving caret by word in visual order.