[webkit-reviews] review denied: [Bug 57233] move directionOfEnclosingBlock() to be global so that it could be reused : [Attachment 87147] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 57233: move directionOfEnclosingBlock() to be global so that it could be
reused
https://bugs.webkit.org/show_bug.cgi?id=57233

Attachment 87147: patch
https://bugs.webkit.org/attachment.cgi?id=87147&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87147&action=review

> Source/WebCore/editing/SelectionController.cpp:339
> +    return
WebCore::directionOfEnclosingBlock(m_selection.extent().anchorNode()); 

This isn't right.  You're calling anchorNode() here even though the original
code called containerNode().