[webkit-reviews] review granted: [Bug 25298] Ctrl + Right/Left arrow move forward/backward through document instead of right/left in RTL text : [Attachment 87131] just test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 06:14:09 PDT 2011


Eric Seidel <eric at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 25298: Ctrl + Right/Left arrow move forward/backward through document
instead of right/left in RTL text
https://bugs.webkit.org/show_bug.cgi?id=25298

Attachment 87131: just	test case
https://bugs.webkit.org/attachment.cgi?id=87131&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87131&action=review

This seems reasonable to me.  Landing this first will make it very easy to see
when we change behavior.

How do the expected results from this test match up with Firefox's behavior? 
IE's behavior?

> LayoutTests/editing/selection/move-left-right-expected.txt:302
> +WARNING: Moved in the wrong direction in step 1: from (791, 574) to (701,
574).

This should probably say FAIL, no?  I geuss you didn't write this test, you
just added to it.


More information about the webkit-reviews mailing list