[webkit-reviews] review requested: [Bug 50951] Add support for text-align:match-parent : [Attachment 87128] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 05:39:25 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 50951: Add support for text-align:match-parent
https://bugs.webkit.org/show_bug.cgi?id=50951

Attachment 87128: Patch
https://bugs.webkit.org/attachment.cgi?id=87128&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87128&action=review

I'd like to see some tests that verify that the computed value of text-align
property is as expected.

> Source/WebCore/css/CSSParser.cpp:791
> +	   // left | right | center | justify | webkit_left | webkit_right |
webkit_center | webkit_match_parent | start |
> +	   // end | <string> | inherit

Nit: you should probably put both start and end on the same line.


More information about the webkit-reviews mailing list