[webkit-reviews] review granted: [Bug 57191] [WIN] Use WCHAR instead of TCHAR : [Attachment 87090] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 28 05:36:39 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 57191: [WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=57191

Attachment 87090: Patch
https://bugs.webkit.org/attachment.cgi?id=87090&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87090&action=review

I'm surprised that the wchar.h includes are needed.

Do you have any opinion on WCHAR vs. wchar_t?

>> Source/WebKit/win/WebKitDLL.cpp:42
>> +#include <wchar.h>
> 
> Alphabetical sorting problem.  [build/include_order] [4]

You should fix this.


More information about the webkit-reviews mailing list