[webkit-reviews] review granted: [Bug 57142] [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer : [Attachment 87119] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 28 04:37:18 PDT 2011
Benjamin Poulain <benjamin at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 57142: [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer
https://bugs.webkit.org/show_bug.cgi?id=57142
Attachment 87119: Patch
https://bugs.webkit.org/attachment.cgi?id=87119&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
The changes in /texmap/ look correct to me.
The change in the Qt implementation does not because of this:
class TextureMapperVideoLayerQt : public virtual TextureMapperMediaLayer
-> the Qt layer is limited to video.
I still r+ because this is improving texture mapper and fixing the Qt layer is
a separate problem. But please open a new bug for having a correct
implementation of TextureMapperMediaLayer for Qt.
More information about the webkit-reviews
mailing list