[webkit-reviews] review granted: [Bug 57186] Web Inspector: refactor ResourceTreeModel to remove poor dependencies. : [Attachment 87081] [PATCH] Same with more informative changelog.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 57186: Web Inspector: refactor ResourceTreeModel to remove poor
dependencies.
https://bugs.webkit.org/show_bug.cgi?id=57186

Attachment 87081: [PATCH] Same with more informative changelog.
https://bugs.webkit.org/attachment.cgi?id=87081&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87081&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:62
> +	  
WebInspector.networkManager.addEventListener(WebInspector.NetworkManager.EventT
ypes.ResourceFinished, this._onResourceUpdated, this);

Please call this before getCachedResources.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:80
> +    frames: function(parentFrameId)

nuke it

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:191
> +	   this._resourcesByURL[resource.url] = resource;

_resourcesByURL -> _resourceByURL