[webkit-reviews] review denied: [Bug 57098] Web Inspector: remove InspectorAgent.reset function from the protocol. : [Attachment 86927] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 57098: Web Inspector: remove InspectorAgent.reset function from the
protocol.
https://bugs.webkit.org/show_bug.cgi?id=57098

Attachment 86927: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=86927&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86927&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:345
>	  
m_frontend->inspector()->inspectedURLChanged(loader->url().string());

inspectedURLChanged is also called from the front-end that will now result in
unnecessary reset. I think we should not call it from the setFrontend and get
it by means of a separate getter message. Otherwise looks good.