[webkit-reviews] review granted: [Bug 57196] Fix script-src redirect handling : [Attachment 87091] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 27 20:51:29 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 57196: Fix script-src redirect handling
https://bugs.webkit.org/show_bug.cgi?id=57196

Attachment 87091: Patch
https://bugs.webkit.org/attachment.cgi?id=87091&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87091&action=review

Seems reasonable.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:261
>      default:

default: is always sub-optimal when dealing with enums.  How many would it be
to list out the rest and have them all break?


More information about the webkit-reviews mailing list