[webkit-reviews] review granted: [Bug 57184] check-webkit-style should check ChangeLog for a valid bug number : [Attachment 87096] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 27 19:26:09 PDT 2011
David Levin <levin at chromium.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 57184: check-webkit-style should check ChangeLog for a valid bug number
https://bugs.webkit.org/show_bug.cgi?id=57184
Attachment 87096: Patch
https://bugs.webkit.org/attachment.cgi?id=87096&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87096&action=review
Awesome. Thanks!
> Tools/Scripts/webkitpy/style/checkers/changelog.py:43
> + for line_number, line in enumerate(entry_lines):
get rid of enumerate here.
> Tools/Scripts/webkitpy/style/checkers/changelog.py:63
> + if line_number == 0:
get rid of comparison to 0.
More information about the webkit-reviews
mailing list