[webkit-reviews] review granted: [Bug 53134] Use Accelerate framework's vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp : [Attachment 87015] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 27 09:35:51 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 53134: Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53134

Attachment 87015: Patch
https://bugs.webkit.org/attachment.cgi?id=87015&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87015&action=review

> Source/JavaScriptCore/ChangeLog:5
> +	   Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp

The changelog is not HTML; entities won't work here.

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:328
> +	       vImage_Flags flags = kvImageNoFlags;
> +	       vImageUnpremultiplyData_RGBA8888(&src, &dst, flags);

You could pass kvImageNoFlags directly.

> LayoutTests/ChangeLog:5
> +	   Use Accelerate framework's vImage vectorized
(un)premultiplyImageData functions for ImageBufferCG.cpp

Remove the entity.

> LayoutTests/ChangeLog:15
> +	     now different. Note: the spec does not define how they *should* be
rounded, so having them there is basically just

But is our rounding compatible with other browsers?


More information about the webkit-reviews mailing list