[webkit-reviews] review granted: [Bug 56245] Text on path positioning at zero startOffset : [Attachment 87035] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 56245: Text on path positioning at zero startOffset
https://bugs.webkit.org/show_bug.cgi?id=56245

Attachment 87035: Patch
https://bugs.webkit.org/attachment.cgi?id=87035&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87035&action=review

Great catch, r=me with one change:

> Source/WebCore/platform/graphics/Path.cpp:108
> +    if (!length)
> +	   traversalState.m_desiredLength = FLT_EPSILON;
> +    else
> +	   traversalState.m_desiredLength = length;

I'd use here traversalState.m_desiredLength = length ? length :
std::numeric_limits<float>::epsilon())