[webkit-reviews] review canceled: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 87006] Step 2, part 1: Add export symbols, and get the wx port using them.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 26 11:05:56 PDT 2011


Kevin Ollivier <kevino at theolliviers.com> has canceled Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 87006: Step 2, part 1: Add export symbols, and get the wx port using
them.
https://bugs.webkit.org/attachment.cgi?id=87006&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
I'm not going to fix the namespace indentation issues in this patch, as doing
so would add hundreds of lines of noise to the patch, and it's already not an
easy patch to review. I can fix it before landing though.

Also, what are we going to do about the gtk and Chromium bots? Do we wait, or
can I land once everything else is green and just fix any issues that crop up?


More information about the webkit-reviews mailing list