[webkit-reviews] review requested: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 87006] Step 2, part 1: Add export symbols, and get the wx port using them.

[bugzilla-daemon at webkit.org]

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 87006: Step 2, part 1: Add export symbols, and get the wx port using
them.
https://bugs.webkit.org/attachment.cgi?id=87006&action=review

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
And here it is finally, the Big Kahuna patch. :) I've tried to export only the
symbols actually used whenever possible, and when I did exported the class
itself, it was due to the need to export the vtable, etc. Note however that
when I export the specific symbols rather than the class itself, MSVC spits out
a ton of warnings, so when we do the Windows port we'll need to either silence
those warnings or be a bit more liberal about exporting classes themselves.
Also, I used JS_EXPORTDATA in a few instances to keep the ports not using the
new export macros building, as mentioned earlier once all ports are moved over
that define will be merged with JS_EXPORT_PRIVATE. 

Oh, and I can vouch that it builds and runs on wx fine and there aren't to my
knowledge any other reviewers familiar with the wx build system, so please
don't hold on the review waiting for someone to verify the wx parts. :)