[webkit-reviews] review granted: [Bug 57127] Add ApplicationCache API to get disk usage per origin : [Attachment 86990] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 16:21:43 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Anton D'Auria
<adauria at apple.com>'s request for review:
Bug 57127: Add ApplicationCache API to get disk usage per origin
https://bugs.webkit.org/show_bug.cgi?id=57127

Attachment 86990: Patch
https://bugs.webkit.org/attachment.cgi?id=86990&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86990&action=review

> Tools/DumpRenderTree/LayoutTestController.cpp:408
> +    JSRetainPtr<JSStringRef> originUrl(Adopt, JSValueToStringCopy(context,
arguments[0], exception));

s/Url/URL/.

> LayoutTests/http/tests/appcache/origin-usage.html:5
> +var drtUrl = "http://127.0.0.1:8000";

You only use this constant sometimes, so I'm not sure if it helps at all.


More information about the webkit-reviews mailing list