[webkit-reviews] review denied: [Bug 54406] png-1.5 fixes : [Attachment 83972] Patch implementing review comments

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Thomas Klausner <tk at giga.or.at>'s
request for review:
Bug 54406: png-1.5 fixes
https://bugs.webkit.org/show_bug.cgi?id=54406

Attachment 83972: Patch implementing review comments
https://bugs.webkit.org/attachment.cgi?id=83972&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83972&action=review

Just a minor fix up needed and then this can go in.

> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:323
> +	   /* '0' argument to png_process_data_pause means: do not save the
data */

Use C++ style comments and whole sentences.

// '0' argument to png_process_data_pause means: Do not save the data.

I was confused by what "saving the data" referred to. From reading
http://libpng.git.sourceforge.net/git/gitweb.cgi?p=libpng/libpng;a=blobdiff;f=l
ibpng-manual.txt;h=3caff8f9b7019891fd3d0b08ce134ea7e99140e2;hp=b34ffcc134340768
7d6723f1132e69f0cdc34941;hb=0a5c9c02faf9c6ceb7acc40e6219e04194581287;hpb=155ce4
021812da5629aaebcc9484094944e7d7ae, it means that png should not cache
unprocessed bytes.


Perhaps something like this instead?
  m_reader->setReadOffset(m_reader->currentBufferSize() -
png_process_data_pause(png, 0 /* Don't cache unprocessed data. */ ));