[webkit-reviews] review granted: [Bug 57119] Microsoft Windows Presentation Foundation (WPF) plug-in complains about missing xpcom.dll : [Attachment 86979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 13:55:55 PDT 2011


Brian Weinstein <bweinstein at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 57119: Microsoft Windows Presentation Foundation (WPF) plug-in complains
about missing xpcom.dll
https://bugs.webkit.org/show_bug.cgi?id=57119

Attachment 86979: Patch
https://bugs.webkit.org/attachment.cgi?id=86979&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86979&action=review

> Source/WebCore/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=57119

Radar link?

> Source/WebCore/plugins/win/PluginPackageWin.cpp:78
> +	   // Bug 57119: Microsoft Windows Presentation Foundation (WPF)
plug-in complains about missing xpcom.dll

It might be nice to say that this is a Mozilla only DLL.

> Source/WebKit2/ChangeLog:7
> +

Ditto about radar link.

> Source/WebKit2/UIProcess/Plugins/win/PluginInfoStoreWin.cpp:364
> +	   // Bug 57119: Microsoft Windows Presentation Foundation (WPF)
plug-in complains about missing xpcom.dll

Ditto about Mozilla-only DLL.


More information about the webkit-reviews mailing list